Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement support in run function for splitting stdout and stderr output + passing down environment to use, and switch to run function for running module commands #4321

Merged
merged 9 commits into from
Aug 11, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 9, 2023

No description provided.

@boegel boegel added this to the 5.0 milestone Aug 9, 2023
@easybuilders easybuilders deleted a comment from boegelbot Aug 11, 2023
easybuild/tools/modules.py Outdated Show resolved Hide resolved
easybuild/tools/modules.py Outdated Show resolved Hide resolved
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just needs the changes @branfosj suggested

ocaisa and others added 2 commits August 11, 2023 15:52
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
@ocaisa
Copy link
Member

ocaisa commented Aug 11, 2023

I committed the changes from @branfosj as they are trivial and consistent with previous usage

@ocaisa ocaisa dismissed branfosj’s stale review August 11, 2023 14:23

Requested changes have been merged

@ocaisa ocaisa merged commit 629b312 into easybuilders:5.0.x Aug 11, 2023
@boegel boegel deleted the run_modules branch August 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants