implement support in 'run' function for running command in different working directory + switch to run function in filetools
#4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working directory
…gure' option of set_up_configuration in EasyBuildLibTest.configure helper method
…thout actually running them in dry run mode
boegel
commented
Aug 15, 2023
| @@ -108,7 +108,7 @@ def cache_aware_func(cmd, *args, **kwargs): | |||
|
|
|||
| @run_cache | |||
| def run(cmd, fail_on_error=True, split_stderr=False, stdin=None, env=None, | |||
| hidden=False, in_dry_run=False, work_dir=None, shell=True, | |||
| hidden=False, in_dry_run=False, verbose_dry_run=False, work_dir=None, shell=True, | |||
There was a problem hiding this comment.
having both hidden (to disable output in both trace and dry run mode) and verbose_dry_run is necessary evil, since there are situations where we do not want trace output, but we do want to see commands that would be executed in dry run mode (primarily in get_source_tarball_from_git)
jfgrimm
reviewed
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.