Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hardcode /bin/bash in eb script, RPATH wrapper script, and run_shell_cmd #4441

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 17, 2024

I was wondering we should provide an EasyBuild configuration option to hard specify the path to bash that should be used, rather than relying on $PATH, but I currently don't see a real need for that. If a need does arise, it can be implemented in a follow-up PR.

fixes #4320

@boegel boegel added bug fix change EESSI Related to EESSI project EasyBuild-5.0 EasyBuild 5.0 labels Jan 17, 2024
@boegel boegel added this to the 5.0 milestone Jan 17, 2024
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, the commands have to work during the build so preferring the one that they make available in their path is sensible (and gives them control)

@ocaisa ocaisa merged commit 2139d3e into easybuilders:5.0.x Jan 18, 2024
35 checks passed
@boegel boegel deleted the bin_bash branch January 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix change EasyBuild-5.0 EasyBuild 5.0 EESSI Related to EESSI project
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants