-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse order for parsing files in XDG_CONFIG_DIRS
#4630
Conversation
https://specifications.freedesktop.org/basedir-spec/latest/ says precedence should be XDG_CONFIG_HOME > 1st entry of XDG_CONFIG_DIRS > 2nd entry ... EasyBuild had this reversed for XDG_CONFIG_DIRS Fixes easybuilders#4582
This is a little easier to understand.
There's a bit of an order of priority issue here with wildcards:
In the present PR I've only reversed the XDG_CONFIG_DIRS-derived list but did not reverse the alphabetical order for wildcards; I also did not change the output after
This list is fed to configparser, last one has priority. If I also change the order in the list displayed after
where the visual expansion flips order, so I decided not to change the output there. If anyone has a better idea how to display, let me know! |
@bartoldeman Can we tweak the language used in |
I change the language as follows, also moving the list on a separate line:
|
E.g.: Default list of existing configuration files (5, most important last): /home/oldeman/lo/easybuild.d/bla.cfg, /home/oldeman/lo/easybuild.d/foo.cfg, /home/oldeman/hi/easybuild.d/bla.cfg, /home/oldeman/hi/easybuild.d/foo.cfg, /home/oldeman/.config/easybuild/config.cfg
dea85d1
to
7ebbee1
Compare
This should be good to go @boegel |
https://specifications.freedesktop.org/basedir-spec/latest/ says precedence should be
XDG_CONFIG_HOME
> 1st entry ofXDG_CONFIG_DIRS
> 2nd entry ...EasyBuild had this reversed for
XDG_CONFIG_DIRS
Fixes #4582