Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for --new-pr when missing commit message #4640

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

Flamefire
Copy link
Contributor

When creating a PR it might be accidental to update an existing file.
Include the name of the updated file in the error message.
For consistency also show the deleted files.

When creating a PR it might be accidental to update an existing file.
Include the name of the updated file in the error message.
For consistency also show the deleted files.
@boegel boegel added this to the 4.x milestone Sep 25, 2024
@boegel boegel changed the title improve error message when missing commit message for --new-pr improve error message for --new-pr when missing commit message Oct 9, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, release after 4.9.4 Oct 9, 2024
@boegel boegel merged commit b9c70d8 into easybuilders:develop Oct 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants