enhance EasyBlock class to allow passing in logfile
#4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thyre
commented
Nov 14, 2024
Thyre
force-pushed
the
easyblock-allow-to-transfer-logger-on-init
branch
from
7119d9e to
a1c36f1
Compare
1 task
Thyre
force-pushed
the
easyblock-allow-to-transfer-logger-on-init
branch
from
a1c36f1 to
e3cb8f0
Compare
Thyre
changed the title
In the case an EasyBlock creates another instance of an EasyBlock (for example when dealing with Bundles), each instance will create new log file, which may stay open and cause issues down the line. To prevent this, add an option to the EasyBlock constructor to pass a logfile from another EasyBlock. Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
Thyre
force-pushed
the
easyblock-allow-to-transfer-logger-on-init
branch
from
e3cb8f0 to
1d18c7e
Compare
4 tasks
|
@boegel If you find any time for a short review, can you look over this PR? |
boegel
changed the title
EasyBlock class to allow passing in logfile
Looks great to me, I didn't see anything that would need to be changed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case an EasyBlock creates another instance of an EasyBlock (for example when dealing with Bundles), each instance will create new log file, which may stay open and cause issues down the line. To prevent this, add an option to the EasyBlock constructor to disable logging to files.
Marked as draft until verified with QuantumESPRESSO and Bundle changes in respective PRs. I want to really make sure that all issues are resolved first.
Related: easybuilders/easybuild-easyconfigs#21841, easybuilders/easybuild-easyblocks#3505