Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc page on easyconfigs index #611

Merged
merged 4 commits into from
Apr 13, 2020
Merged

add doc page on easyconfigs index #611

merged 4 commits into from
Apr 13, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 13, 2020

@boegel boegel added this to the next release (4.2.0) milestone Apr 13, 2020
lexming
lexming reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs for the index look very good. I just fixed some typos and made minor changes to the text. Please, consider them as suggestion and incorporate those that you like.

docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
@boegel boegel mentioned this pull request Apr 13, 2020
Merged
@boegel boegel changed the title add doc page on easyconfigs index (WIP) add doc page on easyconfigs index Apr 13, 2020
lexming
lexming reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three typos and we are good to go

docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
docs/Easyconfigs_index.rst Outdated Show resolved Hide resolved
lexming
lexming approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Apr 13, 2020

Going in, thanks @boegel !

@lexming lexming merged commit 8c8a18c into easybuilders:develop Apr 13, 2020
@boegel boegel deleted the easyconfigs_index branch April 13, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
next release (4.2.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @lexming