Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Plug>(easymotion-overwin-line) not operating over correct range #265

Closed
djjcast opened this issue Jan 21, 2016 · 8 comments
Closed

<Plug>(easymotion-overwin-line) not operating over correct range #265

djjcast opened this issue Jan 21, 2016 · 8 comments

Comments

@djjcast
Copy link

djjcast commented Jan 21, 2016

Test settings:

let g:EasyMotion_do_mapping = 0
nmap \f <Plug>(easymotion-overwin-f2)
xmap \f <Plug>(easymotion-bd-f2)
omap \f <Plug>(easymotion-bd-f2)
nmap \l <Plug>(easymotion-overwin-line)
xmap \l <Plug>(easymotion-bd-jk)
omap \l <Plug>(easymotion-bd-jk)

Test file:

paragraph 1, line 1
paragraph 1, line 2
paragraph 1, line 3
paragraph 1, line 4
paragraph 1, line 5
paragraph 1, line 6
paragraph 1, line 7
paragraph 1, line 8
paragraph 1, line 9
paragraph 1, line 10

paragraph 2, line 1
paragraph 2, line 2
paragraph 2, line 3
paragraph 2, line 4
paragraph 2, line 5
paragraph 2, line 6
paragraph 2, line 7
paragraph 2, line 8
paragraph 2, line 9
paragraph 2, line 10

paragraph 3, line 1
paragraph 3, line 2
paragraph 3, line 3
paragraph 3, line 4
paragraph 3, line 5
paragraph 3, line 6
paragraph 3, line 7
paragraph 3, line 8
paragraph 3, line 9
paragraph 3, line 10

Test procedure:

1. in Normal mode, position the cursor on line 12, column 1
2. type \flig (use `<Plug>(easymotion-overwin-f2)` to jump to line 15, column 14)
3. type \flig (use `<Plug>(easymotion-overwin-f2)` to jump to line 18, column 14)
4. type \lv   (use `<Plug>(easymotion-overwin-line)` to jump to line 12, column 1)
5. type d\lx  (use `<Plug>(easymotion-overwin-line)` to delete from line 12 to line 22, inclusive)

Expected buffer contents (second paragraph is deleted):

paragraph 1, line 2
paragraph 1, line 3
paragraph 1, line 4
paragraph 1, line 5
paragraph 1, line 6
paragraph 1, line 7
paragraph 1, line 8
paragraph 1, line 9
paragraph 1, line 10

paragraph 3, line 1
paragraph 3, line 2
paragraph 3, line 3
paragraph 3, line 4
paragraph 3, line 5
paragraph 3, line 6
paragraph 3, line 7
paragraph 3, line 8
paragraph 3, line 9
paragraph 3, line 10

Actual buffer contents:

paragraph 1, line 2
paragraph 1, line 3
paragraph 1, line 4
paragraph 1, line 5
paragraph 1, line 6
paragraph 1, line 7
paragraph 1, line 8
paragraph 1, line 9
paragraph 1, line 10

paragraph 2, line 1
paragraph 2, line 2
paragraph 2, line 3
paragraph 3, line 1
paragraph 3, line 2
paragraph 3, line 3
paragraph 3, line 4
paragraph 3, line 5
paragraph 3, line 6
paragraph 3, line 7
paragraph 3, line 8
paragraph 3, line 9
paragraph 3, line 10
@haya14busa
Copy link
Member

Thanks for the report! I fixed it.

@djjcast
Copy link
Author

djjcast commented Jan 21, 2016

Wow, that was fast! Thanks for the update - it's working as expected now.

@djjcast
Copy link
Author

djjcast commented Jan 21, 2016

A couple of small issues:

  1. This line (doautocmd WinLeave *) causes the message "No matching autocmds" to be echoed and the "Press ENTER" prompt to be displayed when using <Plug>(easymotion-overwin-line) to switch windows.
  2. A list of errors is echoed when you cancel <Plug>(easymotion-overwin-f2)'s "Search for two characters: " input prompt with "".

@haya14busa
Copy link
Member

I fixed issue 1.
As for the issue 2, what error message is displayed? 'Vim:Interrupt'?

@djjcast
Copy link
Author

djjcast commented Jan 21, 2016

Here's a screenshot of the error:

easymotion-overwin-f2 error

haya14busa added a commit that referenced this issue Jan 21, 2016
@haya14busa
Copy link
Member

I updated the plugin. Can you try it again?

@djjcast
Copy link
Author

djjcast commented Jan 21, 2016

Okay, no more error messages. Thanks!

@haya14busa
Copy link
Member

Thanks for the report! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants