-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(postcss): use default stage 2 #4577
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/build-next-bricks/src/build.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "@next-core/eslint-config-next" to extend from. Please check that the name of the config is correct. The config "@next-core/eslint-config-next" was referenced from the config file in "/.eslintrc". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. Walkthrough此次更改主要集中在两个文件中。首先,在 Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)packages/easyops-runtime/src/websocket/MessageDispatcher.ts (1)
返回类型变更为 Promise 需要注意兼容性 这个改动将
让我们验证一下这个改动的影响范围: packages/build-next-bricks/src/build.js (2)
在
移除了自定义的
建议:
让我们检查是否有依赖特定 CSS 特性的样式: ✅ Verification successfulPostCSS 配置变更影响有限 根据代码库分析,移除自定义配置的影响较小:
建议:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# 搜索可能受影响的 CSS 嵌套规则
rg "@nest|&" -g "*.css" -g "*.less"
Length of output: 37 Script: #!/bin/bash
# 搜索所有 CSS 和 LESS 文件
fd -e css -e less
# 搜索可能使用高级 CSS 特性的文件
rg ":(where|has|is|not|matches|any|local|global|hover|focus|active|visited|target|lang|nth|first|last|only|empty|checked|disabled|enabled|required|valid|invalid|in-range|out-of-range|read-only|read-write|placeholder-shown|default|indeterminate|valid|invalid|optional|required|user-invalid)" -g "*.css" -g "*.less"
# 检查构建配置中是否有其他 PostCSS 相关配置
rg -A 5 "postcss" -g "*.js" -g "*.json"
Length of output: 3271 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #4577 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 206 206
Lines 8938 8938
Branches 1707 1707
=======================================
Hits 8512 8512
Misses 319 319
Partials 107 107
|
next-core Run #10820
Run Properties:
|
Project |
next-core
|
Branch Review |
steve/v3-fix-postcss
|
Run status |
Passed #10820
|
Run duration | 00m 23s |
Commit |
35f7757e6d ℹ️: Merge 5fa5df5156ee1799448fbacaeca08242b21bd216 into 7b3b28aeb872b2a0f79fb7871da2...
|
Committer | Shenwei Wang |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
16
|
View all changes introduced in this branch ↗︎ |
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。Summary by CodeRabbit
新功能
MessageDispatcher
类中的onMessage
方法现在返回一个 Promise,支持异步工作流的更好集成。配置更新
publicPath
属性进行了轻微调整。