-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): fallback to older version of node for cjs #4585
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/babel-preset-next/index.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "@next-core/eslint-config-next" to extend from. Please check that the name of the config is correct. The config "@next-core/eslint-config-next" was referenced from the config file in "/.eslintrc". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. 概述步骤说明该变更修改了 Babel 预设配置中针对 "commonjs" 环境的目标 Node.js 版本。具体而言,目标版本从 "14" 调整为 "12",以支持不支持空值合并运算符的环境。此调整在 变更
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)packages/babel-preset-next/index.js (1)
此更改将 Node.js 目标版本从 “14” 降为 “12”,以兼容无法使用空合并(nullish coalescing)等语法特性的运行环境。建议检查所有与该 Babel 配置相关的依赖或脚本,以确保降级版本不会引发其他兼容性问题。 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #4585 +/- ##
==========================================
- Coverage 95.23% 95.20% -0.04%
==========================================
Files 206 206
Lines 8940 8940
Branches 1707 1707
==========================================
- Hits 8514 8511 -3
- Misses 319 321 +2
- Partials 107 108 +1 |
next-core Run #10851
Run Properties:
|
Project |
next-core
|
Branch Review |
steve/v3-compat
|
Run status |
Passed #10851
|
Run duration | 00m 27s |
Commit |
b594c2c47d ℹ️: Merge a2ffc3f94df8ea257afb28b3f582874f8fc8cf47 into 4d25218a4a78ac613872e14feeb0...
|
Committer | Shenwei Wang |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
16
|
View all changes introduced in this branch ↗︎ |
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。Summary by CodeRabbit