Rename rowmean_n() to row_means()
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #447
|
Still needs some fixing, though. |
Codecov Report
@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 88.61% 88.63% +0.02%
==========================================
Files 71 71
Lines 5182 5192 +10
==========================================
+ Hits 4592 4602 +10
Misses 590 590
|
strengejacke
requested review from
etiennebacher,
IndrajeetPatil and
DominiqueMakowski
NEWS.md
Outdated
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| NEW FUNCTIONS | |||
|
|
|||
| * `rowmean_n()`, to compute row means if row contains at least `n` non-missing | |||
| values. | |||
| * `row_means()`, to compute row means, optionally only for those row with at | |||
There was a problem hiding this comment.
why is it plural means ? doesn't it return just the mean?
There was a problem hiding this comment.
Like rowMeans() from base R, it computes mean_s_ of several rows.
etiennebacher
approved these changes
Aug 15, 2023
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
|
ping @IndrajeetPatil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447