fix labelling

easystats · Oct 3, 2024 · 6b57d38 · 6b57d38
1 parent 13826c5
commit 6b57d38
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -8,6 +8,11 @@
 
 * `get_dispersion()` is now an exported function.
 
+## Bug fix
+
+* `clean_parameters()` now uses the correct labels for the random effects
+  variances (`"SD/Cor"` has changed to `"Var/Cov"`).
+
 # insight 0.20.5
 
 ## General

diff --git a/R/clean_parameters.R b/R/clean_parameters.R
@@ -652,7 +652,7 @@ clean_parameters.mlm <- function(x, ...) {
     if (any(rand_cor)) {
       out$Cleaned_Parameter[which(cor_sd)[rand_cor]] <- paste0(parm1[rand_cor], " ~ ", parm2[rand_cor])
     }
-    out$Group[cor_sd] <- paste("SD/Cor:", gsub("^Sigma\\[(.*):(.*),(.*)\\]", "\\1", out$Parameter[cor_sd], perl = TRUE))
+    out$Group[cor_sd] <- paste("Var/Cov:", gsub("^Sigma\\[(.*):(.*),(.*)\\]", "\\1", out$Parameter[cor_sd], perl = TRUE))
   }
 
 
@@ -669,9 +669,9 @@ clean_parameters.mlm <- function(x, ...) {
       out$Group[rand_effects] <- r_grps
       out$Level[rand_effects] <- r_levels
       # fix labelling of SD and correlation component
-      sd_cor <- grepl("SD/Cor:", out$Group, fixed = TRUE)
+      sd_cor <- grepl("Var/Cov:", out$Group, fixed = TRUE)
       if (any(sd_cor)) {
-        out$Group[sd_cor] <- gsub("SD/Cor: (.*)", "\\1", out$Group[sd_cor])
+        out$Group[sd_cor] <- gsub("Var/Cov: (.*)", "\\1", out$Group[sd_cor])
       }
     } else {
       re_grp_level <- gsub("b\\[(.*) (.*):(.*)\\]", "\\2", out$Cleaned_Parameter[rand_effects])

diff --git a/tests/testthat/test-clean_parameters.R b/tests/testthat/test-clean_parameters.R
@@ -29,3 +29,30 @@ test_that("clean_parameters blavaan", {
   out <- clean_parameters(bfit)
   expect_true(inherits(out, "clean_parameters")) # nolint
 })
+
+
+test_that("clean_parameters stanrag", {
+  skip_on_cran()
+  skip_if_not_installed("rstanarm")
+  skip_if_not_installed("lme4")
+
+  data(sleepstudy, package = "lme4")
+  m <- insight::download_model("stanreg_merMod_6")
+  out <- clean_parameters(m)
+
+  expect_identical(
+    out$Group,
+    c(
+      "", "", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Intercept: Subject", "Days: Subject", "Intercept: Subject",
+      "Days: Subject", "Var/Cov: Subject", "Var/Cov: Subject", "Var/Cov: Subject", ""
+    )
+  )
+})