log instead of throw for failures persisting to session #1

alexwyler · 2019-01-21T23:36:34Z

No description provided.

alexwyler · 2019-01-21T23:37:01Z

alexwyler@Alexs-MBP redisson-tomcat-8 (logging) $ mvn package -Dmaven.test.skip=true
[INFO] Scanning for projects...
[INFO]
[INFO] --------------------< eatstreet:redisson-tomcat-8 >---------------------
[INFO] Building Redisson/Tomcat-8 3.9.1
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ redisson-tomcat-8 ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/alexwyler/redisson-tomcat-8/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ redisson-tomcat-8 ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ redisson-tomcat-8 ---
[INFO] Not copying test resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ redisson-tomcat-8 ---
[INFO] Not compiling test sources
[INFO]
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ redisson-tomcat-8 ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ redisson-tomcat-8 ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.100 s
[INFO] Finished at: 2019-01-21T17:36:49-06:00
[INFO] ------------------------------------------------------------------------

alexwyler · 2019-01-21T23:38:03Z

src/main/java/org/redisson/tomcat/RedissonSession.java

+            }
+        } catch (Exception e) {
+            log.error("Failed to save to session", e);
+            e.printStackTrace();


idk if their appender shows stack traces, and I can't run this code

log instead of throw for failures persisting to session

8afbbe4

alexwyler commented Jan 21, 2019

View reviewed changes

alexwyler merged commit 4cdd624 into master Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

log instead of throw for failures persisting to session #1

log instead of throw for failures persisting to session #1

alexwyler commented Jan 21, 2019

alexwyler commented Jan 21, 2019

alexwyler Jan 21, 2019

log instead of throw for failures persisting to session #1

log instead of throw for failures persisting to session #1

Conversation

alexwyler commented Jan 21, 2019

alexwyler commented Jan 21, 2019

alexwyler Jan 21, 2019

Choose a reason for hiding this comment