Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id to bsCollapsePanel #133

Open
wants to merge 8 commits into
base: shinyBS3
Choose a base branch
from

Conversation

warnes
Copy link

@warnes warnes commented Jan 6, 2021

  • Adds optional id tag to bsColllapsePanel
  • Adds bsCollapseButton and bsCollapseLink functions to generate buttons/links that toggle a bsCollapsePanel.
  • Update Collapse example to use these.

Resolves #132

(Also adds renv environment for development convenience. I'll be glad to drop it if you prefer.)

@warnes
Copy link
Author

warnes commented Jan 6, 2021

To maximize backwards compatibility, the current parameter list for bsCollapsePanel and bsCollapseLink is:

function(title, ..., id, value = title, style = NULL)

with id being optional.

It would better match the usual shiny pattern to put id first, and make both id and title required, thus:

function(id, title, ..., value=id, style=NULL)

…pseLink`.

* Fix issue with `bsCollapseLink` generating `href` attributes with an extra "# ".
* Minor formatting improvement to Collapse demo.
…pseLink`.

* Fix issue with `bsCollapseLink` generating `href` attributes with an extra "# ".
* Minor formatting improvement to Collapse demo.
Merge branch 'bs-collapse-panel-id' of github.com:warnes/shinyBS into bs-collapse-panel-id

# Conflicts:
#	R/bsCollapseButton.R
#	man/bsCollapseButton.Rd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Allow specification of id tag in bsCollapsePanel
1 participant