Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing iss38 (conditionalPanel within bsCollapsePanel). #68

Open
wants to merge 1 commit into
base: shinyBS3
Choose a base branch
from

Conversation

mattflor
Copy link

@mattflor mattflor commented Apr 9, 2016

Hopefully, this fixes issue #38. I am not sure though whether this is just tinkering with the symptoms.
If conditionalPanels are nested within bsCollapsePanels then somehow the sbs-value data array of the parent bsCollapse may contain multiple entries for the same bsCollapsePanel.
Basically, all this fix does is the following:

  • on bsCollapsePanel hide events: remove ALL entries of the bsCollapsePanel to hide from the bsCollapse's sbs-value array, using the new function removeA()
  • on bsCollapsePanel show events: only push the bsCollapsePanel to the sbs-value array if it is not in there already

What I was not able to find out is why multiple entries show up at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant