Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Fix out-of-bounds write #11

Merged
merged 1 commit into from
Aug 26, 2019
Merged

utils: Fix out-of-bounds write #11

merged 1 commit into from
Aug 26, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 25, 2019

We are adding terminating NUL into res[len]. To avoid the invalid write, let's allocate len + 1.

Fixes: ebassi/graphene#168
@ebassi ebassi merged commit e6246c9 into ebassi:master Aug 26, 2019
@jtojnar jtojnar deleted the oob branch August 26, 2019 13:00
jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Aug 26, 2019
Fixes OOB write breaking graphene installed tests:

ebassi/mutest#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphene_quad_t installed test crashes
2 participants