src: fix missing extra ca in tls.rootCertificates

Fixes tls.rootCertificates missing certificates loaded from NODE_EXTRA_CA_CERTS. Fixes: nodejs#32074
ebickle · Mar 17, 2020 · 55a13f8 · 55a13f8
1 parent c351a0e
commit 55a13f8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/node_crypto_common.cc b/src/node_crypto_common.cc
@@ -968,6 +968,16 @@ MaybeLocal<Value> GetPeerCert(
   return result;
 }
 
+MaybeLocal<Value> X509ToPEM(Environment* env, X509* cert) {
+  BIOPointer bio(BIO_new(BIO_s_mem()));
+
+  if (PEM_write_bio_X509(bio.get(), cert) == 0) {
+    return Undefined(env->isolate());
+  }
+
+  return ToV8Value(env, bio);
+}
+
 MaybeLocal<Object> X509ToObject(Environment* env, X509* cert) {
   EscapableHandleScope scope(env->isolate());
   Local<Context> context = env->context();

diff --git a/src/node_crypto_common.h b/src/node_crypto_common.h
@@ -131,6 +131,10 @@ v8::MaybeLocal<v8::Object> X509ToObject(
     Environment* env,
     X509* cert);
 
+v8::MaybeLocal<v8::Value> X509ToPEM(
+    Environment* env,
+    X509* cert);
+
 }  // namespace crypto
 }  // namespace node