filer.open should not ignore onError #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this. |
|
Oh, I've been on my vacation and now I'm glad to be back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, Eric!
I just believe that filer.open should not ignore second param, onError (just as it claimed in docs).
Here's a small fix for this.
If this was intentional or this pull request is inappropriate for some other reason, please, just let all of us know (by "us" I mean the community as a whole ))).
If for some reasons this PR should be somehow improve, I'll be glad to fix all that needed.
It's just that, from my practise, it is almost always better to create issue and a pull request than only issue.
Especially when it looks like you are talking about bug, not some new functionality :)