purego: add float32 and float64 support to callbacks #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajimehoshi
reviewed
Apr 1, 2023
hajimehoshi
reviewed
Apr 1, 2023
This fixes a bug in RegisterFunc which was converting float32 into float64 when the C function expected a float32 argument. This gave unpredictable results. It also makes the behavior of SyscallN more inline with what is expected when calling it with float arguments. It no longer expects them to be float64 and it is up to the caller to convert either float32 or float64 into uintptr. SyscallN will then properly move it into the correct register
hajimehoshi
reviewed
Apr 2, 2023
hajimehoshi
reviewed
Apr 2, 2023
|
I'm gonna sleep soon so I'll take a look tomorrow. Good night... |
Yes! I added a test for that case (TestNewCallbackFloat32AndFloat64) |
TotallyGamerJet
added a commit
to TotallyGamerJet/purego
that referenced
this pull request
Jan 7, 2024
floats and doubles were already implemented in ebitengine#69 ebitengine#120 ebitengine#171 ebitengine#177
TotallyGamerJet
added a commit
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for float32 and float64 arguments in C callbacks. It also adds a test to check the maximum number of arguments a callback can have and that it is callback properly by purego. There is also some formatting done to the assembly.