Consolidate struct definition #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid forgetting to update all the structs I've moved it where every platform shares the same type def. Closes ebitengine#228
|
We should probably add a test for non-standard platforms but this would require a C compiler. |
|
Thanks.
We would need a cross compiler or QEMU. It'd be nice to have. |
hajimehoshi
reviewed
Apr 7, 2024
|
So doing a separate commit for tests? |
If this is easy, it is better to have a test in this pr. If not, a sperate pr is fine. I thought it was not easy. |
|
I don't think it'll be easy |
|
Ok, then let's add a test later in a separate pr :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct on Cgo non-amd64 and non-arm64 platforms didn't have the struct fields updated. To avoid forgetting to update all the structs I've moved it where every platform shares the same type def.
Closes #228