Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Bump minimum Rust version to 1.33 #1

Closed
ebkalderon opened this issue Aug 6, 2019 · 0 comments · Fixed by #2
Closed

Bump minimum Rust version to 1.33 #1

ebkalderon opened this issue Aug 6, 2019 · 0 comments · Fixed by #2
Assignees
Labels
bug Something isn't working

Comments

@ebkalderon
Copy link
Owner

It seems that percent-encoding 2.1.0 is using let bindings in const fn which is causing this CI build to fail on stable Rust 1.31 with the following error:

error: local variables in const fn are unstable
  --> /usr/local/cargo/registry/src/git.luolix.top-1ecc6299db9ec823/percent-encoding-2.1.0/lib.rs:72:13
   |
72 |         let chunk = self.mask[byte as usize / BITS_PER_CHUNK];
   |             ^^^^^

This feature was only stabilized in Rust 1.33 according to this comment. As such, we should probably bump ebkalderon/renderdoc-rs-circleci-dockerfile to a minimum Rust compiler version 1.33.

This issue is a counterpart to ebkalderon/renderdoc-rs#50.

@ebkalderon ebkalderon added the bug Something isn't working label Aug 6, 2019
@ebkalderon ebkalderon self-assigned this Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant