Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate double boxing of compat futures #164

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Eliminate double boxing of compat futures #164

merged 1 commit into from
Mar 7, 2020

Conversation

ebkalderon
Copy link
Owner

Changed

  • Eliminate double boxing of compat futures with a custom BoxFuture type alias.

This should reduce redundant per-request heap allocations for jsonrpc-core significantly.

@ebkalderon ebkalderon self-assigned this Mar 7, 2020
@ebkalderon ebkalderon force-pushed the reduce-double-boxing branch from a51d943 to fc830b3 Compare March 7, 2020 11:40
@ebkalderon
Copy link
Owner Author

This implements the alternative strategy described in paritytech/jsonrpc#485 (comment).

@ebkalderon ebkalderon merged commit e5ea378 into master Mar 7, 2020
@ebkalderon ebkalderon deleted the reduce-double-boxing branch March 7, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ebkalderon ebkalderon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ebkalderon