Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties crashing on vertical mobile views #99

Closed
sigrunixia opened this issue Jun 18, 2024 · 4 comments · Fixed by #105
Closed

Fix properties crashing on vertical mobile views #99

sigrunixia opened this issue Jun 18, 2024 · 4 comments · Fixed by #105

Comments

@sigrunixia
Copy link
Contributor

IMG_3041

As seen here.
Iphone 11 pro max sized screen.

@sigrunixia
Copy link
Contributor Author

Will remove the properties title up top on mobile

@sigrunixia
Copy link
Contributor Author

Okay, so simple hiding is not.. optimal.

Option A

CleanShot 2024-06-27 at 21 40 25

@media screen and (max-width: 700px) {

  .metadata-properties-title {
    margin-bottom: var(--size-4-1);
    padding: var(--size-2-3);
    display: flex;
    justify-content: left;
    font-family: var(--ebw-header-font);
    background-color: rgba(var(--secondary-accent-4-rgb), 0.1);

    &:before {
      display: none;
    }
    &::after {
      display: none;
    }
  }

  .markdown-source-view .metadata-container .metadata-add-button {
    margin-top: revert;
    padding-left: revert;
    position: revert;
    font-size: revert;
    left: revert;
    top: revert;
  }
}

@sigrunixia
Copy link
Contributor Author

Option B

CleanShot 2024-06-27 at 21 42 25

@media screen and (max-width: 700px) {

  .metadata-properties-title {
    display: none;
  }

  .markdown-source-view .metadata-container .metadata-add-button {
    margin-top: revert;
    padding-left: revert;
    position: revert;
    font-size: revert;
    left: revert;
    top: revert;
  }
}

@sigrunixia
Copy link
Contributor Author

sigrunixia commented Jun 28, 2024

I'm leaning towards B because on mobile, if properties are used:

  1. You know its a property.
  2. Real Screen estate is precious

sigrunixia added a commit to sigrunixia/Ebullientworks-Obsidian that referenced this issue Aug 7, 2024
By removing it.

Closes ebullient#99

Signed-off-by: Sigrunixia <Scholarlysigrun@icloud.com>
ebullient pushed a commit that referenced this issue Aug 7, 2024
By removing it.

Closes #99

Signed-off-by: Sigrunixia <Scholarlysigrun@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant