DQA-8663 - Component check improvements. #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, that uses grumphp configuration in component configuration check for orphaned configuration.
…gins of composer.json since int's not installed.
…in the composer.json file.
joaocsilva
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Hi @Ozyrys ,
I have some comments, please have a look and let me know what do you think
Best regards,
João Silva
|
Hi @joaocsilva I have applied your remarks. Please check. |
joaocsilva
reviewed
Mar 6, 2024
|
Hi @joaocsilva I guess that all remarks have been applied. |
joaocsilva
reviewed
Mar 7, 2024
… into feature/DQA-8663
…eric key values or the key itself in 'composer.json'.
|
Hi @joaocsilva I have applied all the remarks from our discussion. Please re-evaluate since all the tests have passed. |
…/toolkit into feature/DQA-8663 # Conflicts: # src/TaskRunner/Commands/ToolCommands.php
jonhy81
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.