Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQA-10218: Allocate npm audit in toolkit #791

Merged
merged 37 commits into from
Nov 14, 2024
Merged

Conversation

LuisSantosEncinas
Copy link
Contributor

No description provided.

@LuisSantosEncinas LuisSantosEncinas changed the title Feature/dqa 10218 DQA-10218: Allocate npm audit in toolkit Nov 7, 2024
@LuisSantosEncinas LuisSantosEncinas marked this pull request as ready for review November 7, 2024 16:31
@jonhy81
Copy link
Contributor

jonhy81 commented Nov 12, 2024

The logic must be changed a bit and split between the component check and the check itself.

Component check:
The npm checks should be included only if in .opts.yml nopm_install is true. Nothing should be processed or displayed if npm_install is false or not defined.

Check itself
Opts.yml should not be used here, keep it simple: find package.json and analyse it.

Copy link
Contributor

@joaocsilva joaocsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuisSantosEncinas ,
Nice work, thank you, will merge and include in the next release.

@joaocsilva joaocsilva merged commit 6b10c8a into release/10.x Nov 14, 2024
2 checks passed
@joaocsilva joaocsilva deleted the feature/DQA-10218 branch November 14, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants