Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re3gistry 2.5.2 restapi error #428

Closed
TeijoKal opened this issue May 30, 2024 · 4 comments
Closed

Re3gistry 2.5.2 restapi error #428

TeijoKal opened this issue May 30, 2024 · 4 comments
Labels
ready for testing Solution is ready to test Type: Bug Something isn't working
Milestone

Comments

@TeijoKal
Copy link

Notice some not so good behaviour when using restapi.

In our 1.3.1 production environment:

https://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211/211.en.json
{
"value": {
"id": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211",
"thisversion": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211:2",
"latestversion": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211",
"historyversion": [
{
"version": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211:1"
}
],
"language": "en",
"label": {
"lang": "fi",
"text": "Kiinnike tai tuki voimajohtoa varten"
},
"description": {
"lang": "fi",
"text": "Lakannut 1999-12-31"
},
"itemclass": {
"id": "CodeListValue",
"label": {
"lang": "en",
"text": "Code list value"
}
},
"status": {
"id": " http://www.luettelopalvelu.fi/registry/status/retired",
"label": {
"lang": "en",
"text": "Retired"
}
},
"register": {
"id": "http://www.luettelopalvelu.fi/codelist",
"label": {
"lang": "en",
"text": "INSPIRE code list register"
},
"registry": {
"id": "http://www.luettelopalvelu.fi/registry",
"label": {
"lang": "en",
"text": "INSPIRE registry"
}
}
},
"codelist": {
"id": "http://www.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji",
"label": {
"lang": "fi",
"text": "KTJkii käyttöoikeusyksikkölaji"
}
}
}
}

But then i tried the following in our demo (Re3gistry 2.5.2) environment:

https://dev.luettelopalvelu.fi/registry/rest?lang=en&uri=http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211&format=json

{
"value": {
"itemclass": {
"label": {
"text": "Codelist",
"lang": "en"
},
"id": "Codelist"
},
"created": "2023-10-27 10:58 AM EEST",
"language": "en",
"definition": {
"text": "

Keskussairaalat

",
"lang": "fi"
},
"id": "http://dev.luettelopalvelu.fi/codelist/RakennuksenTarkkaKayttotarkoitus/211",
"label": {
"text": "Keskussairaalat",
"lang": "fi"
},
"latestversion": "http://dev.luettelopalvelu.fi/codelist/RakennuksenTarkkaKayttotarkoitus/211",
"thisversion": "http://dev.luettelopalvelu.fi/codelist/RakennuksenTarkkaKayttotarkoitus/211:1",
"status": {
"label": {
"text": "Valid",
"lang": "en"
},
"id": "statusbaseuri/status/valid"
},
"register": {
"registry": {
"label": {
"text": "Luettelopalvelu",
"lang": "fi"
},
"id": "http://dev.luettelopalvelu.fi/registry"
},
"label": {
"text": "INSPIRE-koodiluettelorekisteri",
"lang": "fi"
},
"id": "http://dev.luettelopalvelu.fi/codelist"
}
}
}

And it returned wrong data! I checked why this happened and it seems that because the data was not in our dev environment (KTJkiiKayttooikeusyksikkolaji and code value 211). After i added the entry of code value 211 it showed the correct result.

But the question is why it send some other answer that was not asked but the code value was the same 211??? And did not send any error message ??

https://dev.luettelopalvelu.fi/registry/rest?lang=en&uri=http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211&format=json

{
"value": {
"itemclass": {
"label": {
"text": "Codelist",
"lang": "en"
},
"id": "Codelist"
},
"codelist": {
"label": "",
"id": ""
},
"created": "2024-05-30 05:59 AM EEST",
"language": "en",
"definition": {
"text": "

Kiinnike tai tuki voimajohtoa varten

",
"lang": "fi"
},
"id": "http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211",
"label": {
"text": "Kiinnike tai tuki voimajohtoa varten",
"lang": "fi"
},
"latestversion": "http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211",
"thisversion": "http://dev.luettelopalvelu.fi/codelist/KTJkiiKayttooikeusyksikkolaji/211:1",
"status": {
"label": {
"text": "Valid",
"lang": "en"
},
"id": "statusbaseuri/status/valid"
},
"register": {
"registry": {
"label": {
"text": "Luettelopalvelu",
"lang": "fi"
},
"id": "http://dev.luettelopalvelu.fi/registry"
},
"label": {
"text": "INSPIRE-koodiluettelorekisteri",
"lang": "fi"
},
"id": "http://dev.luettelopalvelu.fi/codelist"
}
}
}

@arantzaetxebarria arantzaetxebarria added the under analysis A first analysis is performing label Jun 3, 2024
@iratigarzon
Copy link
Contributor

Dear @TeijoKal,

Thank you for bringing this to our attention. We will look into it.

Best regards,

Irati.

@arantzaetxebarria arantzaetxebarria added this to the v2.6.1 milestone Jun 24, 2024
@TeijoKal
Copy link
Author

TeijoKal commented Jul 1, 2024

Did you managed to reproduce the error?
Do you have any estimate yet to the fix?
This error is only prohibiting to move this version 2 to our production environment.

@iratigarzon
Copy link
Contributor

Dear @TeijoKal,

We have managed to find a solution, which will be available in version 2.6.1. However, could you please provide more information regarding the issue: "This error is only prohibiting us from moving this version 2 to our production environment." Specifically, when you enter all the information, it still prevents you from proceeding ?

Thank you.

Best regards,

Irati.

@TeijoKal
Copy link
Author

I was discussing about this situation with our production people. And the result was that if it is not working reliable and giving wrong replies it is not acceptable to use in production environment.

iratigarzon added a commit that referenced this issue Jul 22, 2024
iratigarzon added a commit that referenced this issue Aug 20, 2024
@arantzaetxebarria arantzaetxebarria added ready for testing Solution is ready to test Type: Bug Something isn't working and removed under analysis A first analysis is performing labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for testing Solution is ready to test Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants