Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editorconfig-linters dependency declaration scope #24

Conversation

kamil-perczynski
Copy link
Contributor

@kamil-perczynski kamil-perczynski commented Jan 23, 2024

Closes #10, but requires some discussion imho.

Although I understand the intent behind direct dependency only on the editorconfig-lint-api and narrowing the scope of the editorconfig-linters, hard-coded adding mavenCentral() causes issues in environments where manual repositories resolution is required: custom repositories resolution.

Specifically, I think about environments where access to software repositories is restricted/proxied due to security reasons (described in #10, I have recent professional experience with such setup - becoming an industry standard I suppose).

Declaring linters package as implementation dependency looks like reasonable step:

  • Sync with dependencies declaration with ec4j-maven-plugin
  • Repositories configuration is 100% on the user side

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kamil-perczynski, what you say sounds reasonable.

@ppalaga ppalaga merged commit 3c1cb3d into ec4j:master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually inject plugin dependencies is very hard
2 participants