Ledger/Speculos TCP APDU transport #288
Conversation
|
Code Climate has analyzed commit 72bca5e and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 47.1% (0.0% change). View more on Code Climate. |
Deploying with
|
| Latest commit: |
72bca5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b3069298.signatory.pages.dev |
| Branch Preview URL: | https://tcp-apdu-transport.signatory.pages.dev |
There was a problem hiding this comment.
on a high level, the documentation is accurate and the behaviour is correct. thank you for the speculos backend support @e-asphyx !
just wanted to double check that the removal of BlockSize from the devices' infos was an intentional change and not by mistake, seems unrelated to the PR. tested on Ledger X, S, and SP.
my first look at the code base, so, please take my comments with a grain of salt. passing around the ctx context as a parameter maybe a classic situation for dependency injection.
lastly, I just noticed, there is a failing check, code climate. max number of returns exceeded
No description provided.