Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to vault_sign_request_duration Prometheus metrics #300

Merged
merged 13 commits into from
Jun 12, 2023
Merged

Add labels to vault_sign_request_duration Prometheus metrics #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a5ddf95
Add address and op labels to vault_sign_request_duration Prometheus m…
danielelisi Feb 18, 2023
1978a60
sg-integrationtest-includebaker add baking operations to allow policy…
May 17, 2023
9c23e50
sg-integrationtest add block operation
May 17, 2023
1210739
sg-integrationtest add aws kms test and simple signatory-cli test
May 23, 2023
621da68
sg-integrationtest missed workflow changes last commit
May 23, 2023
a3171ff
sg-integrationtest revert config file
May 24, 2023
cb2fcf2
Merge branch 'main' into sg-integrationtest-addcli
May 24, 2023
33e007f
sg-integrationtest improve readme
May 24, 2023
f1c77a5
sg-integrationtest fix aws vault test
May 25, 2023
811b22c
Merge branch 'sg-integrationtest-addcli' into vaultsign_add_prometheu…
May 25, 2023
326b96c
fix build break from gotez integration changes
May 25, 2023
c338fcd
Merge branch 'main' into vaultsign_add_prometheus_labels
Jun 9, 2023
2ef983e
fix metric label
Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration_test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ Github secrets are used to define vault env var used in github workflows. To run

### using GCP vault

If you want to run GCP vault tests you need to substitute GCP vault env var into the GCP token file that gets mounted to Signatory file system:

```sh
envsubst < gcp-token-template.json > gcp-token.json
```
Expand Down
16 changes: 9 additions & 7 deletions pkg/metrics/vaultmetrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var (
Name: "vault_sign_request_duration_milliseconds",
Help: "Vaults signing requests latencies in milliseconds",
Buckets: prometheus.ExponentialBuckets(10, 10, 5),
}, []string{"vault"})
}, []string{"vault", "address", "op"})

vaultErrorCounter = prometheus.NewCounterVec(
prometheus.CounterOpts{
Expand All @@ -41,12 +41,14 @@ var (
}, []string{"vault", "code"})
)

// Interceptor function collects sing operation metrics
func Interceptor(opt *signatory.SignInterceptorOptions, sing func() error) error {
timer := prometheus.NewTimer(prometheus.ObserverFunc(func(seconds float64) {
vaultSigningHist.WithLabelValues(opt.Vault).Observe(seconds * 1000)
}))
err := sing()
// Interceptor function collects sign operation metrics
func Interceptor(opt *signatory.SignInterceptorOptions, sign func() error) error {
timer := prometheus.NewTimer(
prometheus.ObserverFunc(
func(seconds float64) {
vaultSigningHist.WithLabelValues(opt.Vault, string(opt.Address.ToBase58()), opt.Req).Observe(seconds * 1000)
}))
err := sign()
timer.ObserveDuration()

if err != nil {
Expand Down