-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and publish Docker image previews from branches #349
Conversation
Code Climate has analyzed commit ade8a7f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 47.4% (0.0% change). View more on Code Climate. |
Deploying with Cloudflare Pages
|
refactor(build.yaml): remove unnecessary echo statement
feat(build.yaml): use format function to generate images input for Docker Manifest GitHub Action
build.yaml: - Add echo statements to print github.sha and github event - Update actions/checkout to v3 goreleaser.yml: - Update image_templates to use FullCommit instead of Branch for snapshots - Update snapshot name_template to use FullCommit instead of ShortCommit
…d.sha instead of sha
5e09d96
to
fb72d17
Compare
a424835
to
6c1a4d4
Compare
…natory and signatory-cli feat(.goreleaser.yml): add snapshot name template using short commit hash
6c1a4d4
to
80ef08f
Compare
…o tag Docker images appropriately, and update push step to use a single run command
…Windows, and add support for ARM architecture on MacOS.
b08b94b
to
716e65d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM 🚀
Build preview Docker images for Signatory when a PR is created. The images are pushed to GHCR which is currently a private container repo. https://github.com/ecadlabs/signatory/pkgs/container/signatory
I've edited the
.goreleaser.yml
with conditionals to account for different Docker tags whengoreleaser
is run from a branch and with the--snapshot
flag enabled.As part of this PR I also cleaned up the
build.yml
workflow files by deleting unnecessary steps.