Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish Docker image previews from branches #349

Merged
merged 24 commits into from
Apr 28, 2023

Conversation

danielelisi
Copy link
Contributor

@danielelisi danielelisi commented Apr 27, 2023

Build preview Docker images for Signatory when a PR is created. The images are pushed to GHCR which is currently a private container repo. https://github.com/ecadlabs/signatory/pkgs/container/signatory

I've edited the .goreleaser.yml with conditionals to account for different Docker tags when goreleaser is run from a branch and with the --snapshot flag enabled.

As part of this PR I also cleaned up the build.yml workflow files by deleting unnecessary steps.

@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit ade8a7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.4% (0.0% change).

View more on Code Climate.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 716e65d
Status: ✅  Deploy successful!
Preview URL: https://e2a679ba.signatory.pages.dev
Branch Preview URL: https://docker-images-branch-preview.signatory.pages.dev

View logs

refactor(build.yaml): remove unnecessary echo statement
feat(build.yaml): use format function to generate images input for Docker Manifest GitHub Action
build.yaml:
- Add echo statements to print github.sha and github event
- Update actions/checkout to v3

goreleaser.yml:
- Update image_templates to use FullCommit instead of Branch for snapshots
- Update snapshot name_template to use FullCommit instead of ShortCommit
@danielelisi danielelisi force-pushed the docker_images_branch_preview branch from 5e09d96 to fb72d17 Compare April 28, 2023 01:47
@danielelisi danielelisi force-pushed the docker_images_branch_preview branch 5 times, most recently from a424835 to 6c1a4d4 Compare April 28, 2023 17:20
…natory and signatory-cli

feat(.goreleaser.yml): add snapshot name template using short commit hash
@danielelisi danielelisi force-pushed the docker_images_branch_preview branch from 6c1a4d4 to 80ef08f Compare April 28, 2023 17:36
…o tag Docker images appropriately, and update push step to use a single run command
@danielelisi danielelisi requested a review from GImbrailo April 28, 2023 20:48
…Windows, and add support for ARM architecture on MacOS.
@danielelisi danielelisi force-pushed the docker_images_branch_preview branch from b08b94b to 716e65d Compare April 28, 2023 20:54
Copy link
Contributor

@GImbrailo GImbrailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM 🚀

@danielelisi danielelisi merged commit c907732 into main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants