-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go to version v1.21.0 and all dependencies #433
Conversation
74e4bfc
to
3b6e325
Compare
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need:
steps: - uses: actions/setup-go@v3 with: go-version: '1.21.0'
on jobs {test, integration-tests,report-coverage}
anywhere that we call go, so that we are sure to be testing and building coverage reports with the same version of go that goreleaser-cross is building with
also, FWIW, 1.21.0 is also available on docker hub now, so, both registries would work now |
Thanks for catching this |
Ah yes I just checked. Might as well we stick with ghcr.io if updated images are released faster there |
As per title.
Go
v1.21.0
was released so I upgradedgoreleaser-cross
to the latest version to use the latest version of Go. Sincegoreleaser-cross:v1.21.0
isn't available on Dockerhub registry I pointed the image to GHCR which hasv1.21.0
already available.I've also upgraded all dependencies to their latest versions with