Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go to version v1.21.0 and all dependencies #433

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

danielelisi
Copy link
Contributor

@danielelisi danielelisi commented Aug 10, 2023

As per title.

Go v1.21.0 was released so I upgraded goreleaser-cross to the latest version to use the latest version of Go. Since goreleaser-cross:v1.21.0 isn't available on Dockerhub registry I pointed the image to GHCR which has v1.21.0 already available.

I've also upgraded all dependencies to their latest versions with

$ go get -u ./...
$ go mod tidy

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 888f2d4
Status: ✅  Deploy successful!
Preview URL: https://06808063.signatory.pages.dev
Branch Preview URL: https://upgrade-go-121.signatory.pages.dev

View logs

Copy link
Contributor

@stephengaudet stephengaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need:
steps: - uses: actions/setup-go@v3 with: go-version: '1.21.0'

on jobs {test, integration-tests,report-coverage}
anywhere that we call go, so that we are sure to be testing and building coverage reports with the same version of go that goreleaser-cross is building with

@stephengaudet
Copy link
Contributor

also, FWIW, 1.21.0 is also available on docker hub now, so, both registries would work now

@danielelisi
Copy link
Contributor Author

I think we need: steps: - uses: actions/setup-go@v3 with: go-version: '1.21.0'

on jobs {test, integration-tests,report-coverage} anywhere that we call go, so that we are sure to be testing and building coverage reports with the same version of go that goreleaser-cross is building with

Thanks for catching this

@danielelisi
Copy link
Contributor Author

also, FWIW, 1.21.0 is also available on docker hub now, so, both registries would work now

Ah yes I just checked. Might as well we stick with ghcr.io if updated images are released faster there

@stephengaudet stephengaudet self-requested a review August 10, 2023 20:11
@danielelisi danielelisi merged commit 7374c12 into main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants