-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashicorp vault support #439
hashicorp vault support #439
Conversation
thank you for your contribution @denisandreenko I'll have this PR tested shortly |
Ideally, test results would be communicated in an Issue, and not in a PR. Please give a read of the contributions section of the readme https://github.com/ecadlabs/signatory#contributions currently the signatory-cli binary does not recognize the new vault driver. the signatory binary starts and authenticates with the configured vault, but, the signatory-cli fails to execute using the same signatory.yaml config file
with the same file, signatory is fine: |
Hi @stephengaudet ✋ Thanks for the hint, I'll do the following PR through issues. Added HCP init for Signatory CLI |
hi @denisandreenko 👋 the integration test I've developed gets some decent coverage of the new vault with a statement coverage of 69.4%. the other 30% is mostly error handling. with 2 exceptions. my tests are not reaching the following 2 functions: Are these unreachable code? github.com/ecadlabs/signatory/pkg/vault/hashicorp/vault.go:44: PublicKey 100.0% |
Hi @stephengaudet 👋 Thank you so much for your work! That's right, these methods are not used at the moment, however they can be very useful for users who want to check the signed message for validity. |
thanks @denisandreenko ! My preference would be to remove the unused functions. that said, I'm not here to stifle innovation. :) |
For cases when octez-client is not used or if we want to check it before sending a transaction to the blockchain. |
Hi @stephengaudet 👋 Are there any other comments? |
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
ac1a924
to
8a03867
Compare
Thanks @stephengaudet 👍 Did a rebase and merged conflicts. |
🚀 Pull Request: New Integration with HashiCorp Vault Transit for Tezos Transaction Signing
📝 Description:
This pull request introduces an exciting new feature that enhances service's flexibility. I've integrated HashiCorp Vault's Transit Secrets Engine to manage the signing of Tezos transactions.
🛠️ Implementation Details:
🔒 Security Considerations:
📑 Documentation Updates:
Please review the code changes, test results, and documentation updates. Your feedback and suggestions are greatly appreciated!
🙌 Thank you for your attention and support!