Unicode 15.1 linebreaking #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experimental implementation of the line breaking rules proposed in the Unicode document L2/22-080R. It is not suitable for merging into ICU main. Limitations: - ICU4C only. - Root locale only (not implemented for the various LB tailorings). - New Line Break properties implemented with hard-coded UnicodeSets. (unmaintainable) - RBBIMonkeyTest not updated. (There are two ICU monkey tests; the other is updated.)
markusicu
reviewed
Jun 29, 2023
| UnicodeString(rules, -1, US_INV), 0, status); | ||
| UnicodeString CMx {uR"([[\p{Line_Break=CM}]\u200d])"}; | ||
| UnicodeString rules; | ||
| rules = rules + u"((\\p{Line_Break=PR}|\\p{Line_Break=PO})(" + CMx + u")*)?" |
There was a problem hiding this comment.
optional / simpler:
UnicodeString rules =
u"..."
u"..."
u"...";
using C++ string literal concatenation in the compiler.
There was a problem hiding this comment.
That does not work: CMx is not a literal (it would work if we made it a macro; do we want that?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[175-C23] Consensus: Replace rule LB 15 by LB 15a and LB 15b in UAX #14, as described in L2/23-063 Line breaking around quotation marks, changing the references to the sets [:Pi:] and [:Pf:] to [[:Pi:]&QU] and [[:Pf:]&QU], respectively, for Unicode Version 15.1.
[175-C27] Consensus: Add line breaking classes AF, AK, AP, AS, VI, and VF, as well as a new line breaking rule LB 28b, and change Line_Break property values, as described in L2/23-072.