Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(ubuntu): Enable code coverage for gunittest-based tests #168

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

echoix
Copy link
Owner

@echoix echoix commented Jul 21, 2024

No description provided.

@github-actions github-actions bot added the CI label Jul 21, 2024
@echoix echoix changed the title CI(ubuntu): Create a tag for artifact uploads with length limit for a matrix combination CI(ubuntu): Enable code coverage for gunittest-based tests Jul 21, 2024
@echoix echoix force-pushed the gunittest-coverage branch 11 times, most recently from a4a985a to 4c1c385 Compare July 24, 2024 17:24
@echoix
Copy link
Owner Author

echoix commented Jul 24, 2024

@ninsbl do you have some ideas on what is so special about these couple tests that fail (the only ones). It seems like a crash between C and Python code, for temporal. Why would it only be temporal that crashes getting the driver name? Yes there’s now coverage interfering, but it might be that the bottleneck that we were trying to chase for months.
https://github.com/echoix/grass/actions/runs/10081203143/job/27872701578?pr=168#step:17:92

I’m placing a link to the run, since I will be continuing to rebase (I had 57 debugging commits to sort out, since it was working locally but not on CI, or worked on CI when installing a Python version and not relying on the Ubuntu one)

@echoix
Copy link
Owner Author

echoix commented Jul 24, 2024

I've managed to get it not fail with the SIGTERM option off. The SIGTERM wouldn't work on Windows, only Linux and macOS. https://coverage.readthedocs.io/en/latest/subprocess.html#process-termination https://coverage.readthedocs.io/en/latest/config.html#run-sigterm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant