-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI(ubuntu): Enable code coverage for gunittest-based tests #168
base: main
Are you sure you want to change the base?
Conversation
6cb687f
to
1ecb440
Compare
a4a985a
to
4c1c385
Compare
@ninsbl do you have some ideas on what is so special about these couple tests that fail (the only ones). It seems like a crash between C and Python code, for temporal. Why would it only be temporal that crashes getting the driver name? Yes there’s now coverage interfering, but it might be that the bottleneck that we were trying to chase for months. I’m placing a link to the run, since I will be continuing to rebase (I had 57 debugging commits to sort out, since it was working locally but not on CI, or worked on CI when installing a Python version and not relying on the Ubuntu one) |
I've managed to get it not fail with the SIGTERM option off. The SIGTERM wouldn't work on Windows, only Linux and macOS. https://coverage.readthedocs.io/en/latest/subprocess.html#process-termination https://coverage.readthedocs.io/en/latest/config.html#run-sigterm |
de3537c
to
567a642
Compare
5fe2fbc
to
1f25a2e
Compare
1f25a2e
to
047805c
Compare
… matrix combination
Remove unused setting of coverage env var in test step
Revert "CI(ubuntu): Set INITIAL_PWD env var as export instead of inline" This reverts commit 5b3198a. CI(ubuntu): Un-ignore testreport folders CI(ubuntu): Un-ignore testreport root folder Revert "CI(ubuntu): Un-ignore testreport folders" This reverts commit 664c302. Update ubuntu.yml Update ubuntu.yml Update ubuntu.yml usercustomize
047805c
to
50227ef
Compare
No description provided.