Improve delegation tx management #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case of additionalWitnesses is still unclear how to precisely calculate the bytes for witnesses
|
There are good ideas here but i think it would be better to split this in two PRs, one for the tx witness update and other for the bech32 stuff, that works for you? @safanaj |
|
Hi @echovl, yes it does for me. Also I will cleanup (maybe put a 3rd PR) for the cardano-cli changes (that are not well shaped (just used in one of my little stuff for convenience. I will submit a PR to propose Node iface improvement adding the koios support |
|
Close this PR in favor of 2 split ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #37
This closes #38
This will add some minimal (opinionated) helper functions regarding bech32 (also exposing these) and stake address management.
The core of this proposal is the tx builder improvement to be able to set in advance a number of expected witness aiming for the correct fee calculation, allowing us to build a tx that is partially signed.
In my case I am using it to build a tx that include a stake delegation cert, and the only "payment" input is owned by someone that is not the owner of the stake key. In this way I prepare in the backend the tx (paying the delegation tx fee) and propose the 3rd part to sign the tx w/o spending nothing.
I guess the code is more clear that my explanation.