-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for StakeAddress and BaseAddress output #46
base: master
Are you sure you want to change the base?
Conversation
@safanaj it was too late when I finished implementing StakeAddress management on my own and later found out you've done similar work in #41 PR... |
@echovl Could you allow few more people to review PRs and have write access to the repo so that they can merge PRs as well? Hope this repo to be a bit more responsive and prosper :) |
Agree, yes I will. Only I saw that on my PR in address.go there are 2 typo fixes in the NewAddressFromBytes constructor, regarding the error message for Ptr address type if those make sense to you too add them. @echovl if you are still short with time probably as suggested by @kevink1103 you could allow us to review and merge. |
Hi guys, sorry for the late reply, this looks good to me. Do we really need the bech32 PR merged first? |
Just to follow up on this PR. For those who are interested in this PR, use the forked one! |
This PR includes:
Wallet.Addresses()
and replace it withWallet.EnterpriseAddresses()
Wallet.Keys()
and replace it withWallet.PrvKeys()
Wallet.BaseAddresses()
StakeAddress
support forAddress
andWallet
PoolCost
inpoolRegistration
structcloses #45
closes #20