-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node resource availability #378
Add node resource availability #378
Conversation
@HorjuRares: I see after approving the last run that 4 stests are failing, maybe due to some reasons known in #363. Maybe you can have a look. I am not totally finished with the review, but you can still address the comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review not finished, but @HorjuRares told me that he will introduce major changes now. So please check if the findings are still matching or otherwise fix them with the new major changes and respond to each of the comment.
Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com>
Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review finished. Findings published.
@HorjuRares: We need to check the filtering again. And also the control interface examples. |
Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com>
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done. Findings documented.
I saw some requirements that are changed without a version update. Please check and update them.
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder a bit about the space between the value and % and B in the cli output.
@windsource, what do you think?
Otherwise, LGTM 👍
@krucod3 I think there should be no space. Linux commands like |
Issues: #282
Added a functionality that enables the measurement of node resource availability for each connected agent
Changes: