Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node resource availability #378

Merged

Conversation

HorjuRares
Copy link
Contributor

@HorjuRares HorjuRares commented Sep 17, 2024

Issues: #282

Added a functionality that enables the measurement of node resource availability for each connected agent

Changes:

  • modified the internal structure in order to accommodate the agent load
  • the agent manager periodically sends info about the available load
  • added a new message "AgentLoadStatus"
  • added/modified relevant unit tests
  • updated the description

@HorjuRares HorjuRares marked this pull request as draft September 17, 2024 12:43
@HorjuRares HorjuRares marked this pull request as ready for review October 1, 2024 09:01
@inf17101 inf17101 added enhancement New feature or request. Issue will appear in the change log "Features" ready for review labels Oct 1, 2024
@inf17101 inf17101 changed the title 282 node resource availability Add node resource availability Oct 1, 2024
@inf17101
Copy link
Contributor

inf17101 commented Oct 4, 2024

@HorjuRares: I see after approving the last run that 4 stests are failing, maybe due to some reasons known in #363. Maybe you can have a look.

I am not totally finished with the review, but you can still address the comment above.

Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review not finished, but @HorjuRares told me that he will introduce major changes now. So please check if the findings are still matching or otherwise fix them with the new major changes and respond to each of the comment.

agent/doc/swdesign/README.md Outdated Show resolved Hide resolved
agent/src/agent_manager.rs Show resolved Hide resolved
ank/doc/swdesign/README.md Outdated Show resolved Hide resolved
ank/src/cli_commands/get_agents.rs Outdated Show resolved Hide resolved
common/doc/swdesign/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished. Findings published.

ank/src/filtered_complete_state.rs Outdated Show resolved Hide resolved
api/proto/ank_base.proto Outdated Show resolved Hide resolved
api/proto/ank_base.proto Outdated Show resolved Hide resolved
common/src/objects/agent_map.rs Outdated Show resolved Hide resolved
common/src/objects/agent_map.rs Outdated Show resolved Hide resolved
grpc/src/to_server_proxy.rs Outdated Show resolved Hide resolved
grpc/src/to_server_proxy.rs Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Show resolved Hide resolved
server/src/ankaios_server.rs Show resolved Hide resolved
@inf17101
Copy link
Contributor

inf17101 commented Oct 7, 2024

@HorjuRares: We need to check the filtering again. And also the control interface examples.
Try to filter for a certain agent attribute like cpu usage and see if the filtering works.

api/proto/ank_base.proto Outdated Show resolved Hide resolved
agent/doc/swdesign/README.md Outdated Show resolved Hide resolved
agent/doc/swdesign/README.md Outdated Show resolved Hide resolved
agent/src/agent_manager.rs Outdated Show resolved Hide resolved
ank/doc/swdesign/README.md Outdated Show resolved Hide resolved
ank/src/cli_commands/get_agents.rs Outdated Show resolved Hide resolved
api/proto/ank_base.proto Outdated Show resolved Hide resolved
common/src/objects/agent_map.rs Outdated Show resolved Hide resolved
doc/docs/usage/tutorial-vehicle-signals.md Outdated Show resolved Hide resolved
grpc/proto/grpc_api.proto Outdated Show resolved Hide resolved
ank/src/cli_commands/get_agents.rs Outdated Show resolved Hide resolved
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. Findings documented.

I saw some requirements that are changed without a version update. Please check and update them.

grpc/src/to_server_proxy.rs Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/src/ankaios_server.rs Outdated Show resolved Hide resolved
tests/resources/ankaios.resource Outdated Show resolved Hide resolved
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder a bit about the space between the value and % and B in the cli output.
@windsource, what do you think?

Otherwise, LGTM 👍

@windsource
Copy link
Contributor

@krucod3 I think there should be no space. Linux commands like ls -lh usually do not print spaces there.

@krucod3 krucod3 merged commit 76d5773 into eclipse-ankaios:main Oct 16, 2024
10 checks passed
@HorjuRares HorjuRares deleted the 282_node_resource_availability branch November 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Issue will appear in the change log "Features" ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants