Initial draft for config files #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windsource
requested changes
Dec 16, 2024
agent/config/ank-agent.conf
Outdated
Comment on lines
18
to
19
| # An existing path where to manage the fifo files. | ||
| # run-folder = '/tmp/ankaios/' |
There was a problem hiding this comment.
That is not clear to me. Has the user to create that folder? I have never done that.
Comment on lines
+27
to
+29
| # This shall be used to manage eventual persistency. | ||
| # !!! At the moment, it is not implemented. | ||
| # max_workload_start_retry_time = '300' # seconds |
There was a problem hiding this comment.
If this is not implemented yet, we should delete it.
krucod3
reviewed
Dec 16, 2024
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com> Co-authored-by: Holger Dormann <windsource@gmx.de>
Co-authored-by: Holger Dormann <windsource@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #302
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.