Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wildcard auth rule for empty filed masks #428

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Conversation

krucod3
Copy link
Contributor

@krucod3 krucod3 commented Jan 8, 2025

Issues: #427

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@krucod3 krucod3 changed the title 427 fix wildcard auth Fix wildcard auth rule for empty filed masks Jan 8, 2025
@krucod3 krucod3 added ready for review bug Something isn't working. Issue will appear in the change log "Bug Fixes" labels Jan 8, 2025
Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished.

agent/doc/swdesign/README.md Outdated Show resolved Hide resolved
agent/src/control_interface/authorizer.rs Show resolved Hide resolved
Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@inf17101 inf17101 merged commit 38c859f into main Jan 9, 2025
10 checks passed
@inf17101 inf17101 deleted the 427_fix_wildcard_auth branch January 9, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Issue will appear in the change log "Bug Fixes" ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants