This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Allow to specify BUILD_ALIAS #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apodhrad
added a commit
to apodhrad/reddeer
that referenced
this pull request
May 26, 2017
apodhrad
added a commit
to apodhrad/reddeer
that referenced
this pull request
May 26, 2017
Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
apodhrad
added a commit
to apodhrad/reddeer
that referenced
this pull request
May 26, 2017
Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
|
Now, you can also specify BUILD_TIMESTAMP (by default 'yyyyMMdd-HHmm').So, the version format looks like |
rawagner
reviewed
May 29, 2017
| </dependencies> | ||
| <configuration> | ||
| <strictBinIncludes>false</strictBinIncludes> | ||
| <format>'${BUILD_ALIAS}-v'${BUILD_TIMESTAMP}</format> |
There was a problem hiding this comment.
why not ${BUILD_ALIAS}.v'${BUILD_TIMESTAMP}. Ie eclipse.core is using dot instead of dash
There was a problem hiding this comment.
I used the jbosstools format since eclipse doesn't use the BUILD_ALIAS. Of course, we can discuss which format is best for our purpose.
There was a problem hiding this comment.
Moreover, I like the dash ;-)
|
Unfortunately, it is not possible to update from to |
Signed-off-by: Andrej Podhradsky <apodhrad@redhat.com>
|
Changed the default build alias to 'CI' so that a user can update to the final bits. |
|
Moreover, I think it is ok to have a timestamp for any BUILD_ALIAS. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to specify BUILD_ALIAS such as