Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Issue-1958 Updating aeri dependencies from #1974

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

jkopriva
Copy link
Contributor

org.eclipse.reddeer.eclipse.test and fixing categories in
org.eclipse.reddeer.workbench.test.ui

Signed-off-by: Josef Kopriva jkopriva@redhat.com

@odockal
Copy link
Collaborator

odockal commented Nov 22, 2018

@jkopriva Nice, have you tried to build locally and install?

@odockal
Copy link
Collaborator

odockal commented Nov 22, 2018

@jkopriva Some tests are broken, could you please take a look? https://ci.eclipse.org/reddeer/job/reddeer.prcheck.2018-12/22/#showFailuresLink

org.eclipse.reddeer.workbench.test.ui

Signed-off-by: Josef Kopriva <jkopriva@redhat.com>
@odockal
Copy link
Collaborator

odockal commented Nov 28, 2018

testPR

@@ -15,16 +15,16 @@
<plugin>
<extension point="org.eclipse.ui.views">
<category
id="org.eclipse.reddeer.workbench.test.ui.category"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be just an id value, that is referenced elsewhere. This wont fix anything. (probably nor break anything, but I would keep it different from possible package name collision - so please, do not change category id and its references)

@odockal odockal dismissed their stale review November 28, 2018 09:25

We decided to keep the changes as they are now.

@odockal odockal merged commit d4889f5 into eclipse-archived:master Nov 28, 2018
@odockal
Copy link
Collaborator

odockal commented Nov 28, 2018

Failing tests will be repaired in another PR.

@odockal odockal changed the title Issue-1958 Removing aeri dependencies from Issue-1958 Updating aeri dependencies from Nov 28, 2018
@odockal
Copy link
Collaborator

odockal commented Nov 28, 2018

Only warning left after RD installation into Devstudio:

eclipse.buildId=12.10.0.AM1-v20181128-0454-B3667
java.version=1.8.0_191
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Framework arguments:  -product com.jboss.devstudio.core.product
Command-line arguments:  -data file:/home/odockal/workspace12100AM1-1128/ -os linux -ws gtk -arch x86_64 -product com.jboss.devstudio.core.product

org.eclipse.e4.ui.workbench
Warning
Wed Nov 28 10:43:36 CET 2018
Removing part descriptor with the 'org.eclipse.reddeer.workbench.test.ui.views.dirtylabelview' id and the 'Workbench Dirty Test' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class.

Partially fixes #1958 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants