Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[Compact Profile 2] Javasound bundle depends on Full JRE #5328

Closed
svilenvul opened this issue Mar 30, 2018 · 1 comment
Closed

[Compact Profile 2] Javasound bundle depends on Full JRE #5328

svilenvul opened this issue Mar 30, 2018 · 1 comment

Comments

@svilenvul
Copy link
Contributor

Looking at the report generated by openhab/static-code-analysis#283, I see that one package in org.eclipse.smarthome.io.javasound bundle depends on javax.sound.sampled.

This is a violation of C.1 in the ESH coding guidelines https://www.eclipse.org/smarthome/documentation/development/guidelines.html#c-language-levels-and-libraries.
sjsf pushed a commit to sjsf/smarthome that referenced this issue Apr 20, 2018
remove javax.sound.sampled import from o.e.sh.io.javasound
4ef9b1e 
fixes eclipse-archived#5328
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@sjsf sjsf mentioned this issue Apr 20, 2018
Closed
@sjsf
Copy link
Contributor

sjsf commented Apr 23, 2018

@svilenvul We'll need an exception for this bundle (org.eclipse.smarthome.io.javasound)

@sjsf sjsf closed this as completed Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove javax.sound.sampled import from o.e.sh.io.javasound sjsf/smarthome
2 participants
@sjsf @svilenvul