Add StartUnit operation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to add per-request-type data to the request. Signed-off-by: Alexander Larsson <alexl@redhat.com>
We're gonna need this to track when our requests complete. Signed-off-by: Alexander Larsson <alexl@redhat.com>
|
This is initial work on #91 |
sdunnagan
reviewed
Feb 1, 2023
sdunnagan
reviewed
Feb 1, 2023
sdunnagan
reviewed
Feb 1, 2023
sdunnagan
reviewed
Feb 1, 2023
sdunnagan
approved these changes
Feb 1, 2023
This calls StartUnit on the agent, and if that succeeds it signals the availability of a new job object and returns its object path. Eventually the agent will detect the matching JobRemoved signal from systemd and will send a JobDone to the manager, which will then emit a JobRemoved on the hirte job object. Compared to the dbus API document some things are missing: * There is no queueing of conflicting operations * We don't support properties on the Job object. Signed-off-by: Alexander Larsson <alexl@redhat.com>
alexlarsson
force-pushed
the
start-unit
branch
from
b7440eb
to
ad2afc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This calls StartUnit on the agent, and if that succeeds it signals
the availability of a new job object and returns its object path.
Eventually the agent will detect the matching JobRemoved signal from
systemd and will send a JobDone to the manager, which will then
emit a JobRemoved on the hirte job object.
Compared to the dbus API document some things are missing: