Implement StopUnit and flesh out Job object #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use this code for all operations that create a job. Also, make it refcount to streamline some of the memory ownership tracking. Signed-off-by: Alexander Larsson <alexl@redhat.com>
All the operations that track a job like StartUnit can reuse this type. Also, make it refcounted to make the ownership handling clearer. Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
We use a filter that runs before the vtable functions and ensure that all Node operations always handle offline nodes in a central place. This simplifies the method implementations and makes sure we don't miss the check somewhere. Signed-off-by: Alexander Larsson <alexl@redhat.com>
This is similar to _SD_DEFINE_POINTER_CLEANUP_FUNC and means we don't have to repeat all these identical cleanup functions. Signed-off-by: Alexander Larsson <alexl@redhat.com>
The actual implementation of the job side in the agent ended up a bit different, as we don't need a real job object for the agent side. We just reuse the unique id of the public job object to hang everything off. Signed-off-by: Alexander Larsson <alexl@redhat.com>
Whereever we have `if(ptr) unref(ptr)` we now use unrefp(&ptr) which makes the code cleaner with less unneccesary indentation. Signed-off-by: Alexander Larsson <alexl@redhat.com>
After implementing this I don't think we need to do any queueing on the manager side. We already pass the mode to the agent which will give it to systemd, which does the queueing. We just need to propagate the WAITING => RUNNING state change. Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
engelmi
reviewed
Feb 2, 2023
engelmi
approved these changes
Feb 2, 2023
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support both starting and stopping object, and there are some initial work on properties for the job and node (although no property change notification yet).
Also includes some overall cleanups and fixing up the dbus API where it differs from the implemented API (primarily in the internals).