Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install default config files #125

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

ArtiomDivak
Copy link
Contributor

@ArtiomDivak ArtiomDivak commented Feb 9, 2023

Installs default config files to /etc directory:

  • hirte.conf - a configuration file for the hirte daemon
  • hirte-agent.conf - a configuration file for the hirte-agent daemon

Signed-off-by: ArtiomDivak adivak@redhat.com

@alexlarsson
Copy link
Contributor

alexlarsson commented Feb 9, 2023

I think the idea of having some default config files is good, but the contents of these ones are very much not what we want to ship to users as some kind of default, its more like an example. Also, this is based on some older versions of the example files and loses recent changes.

I also don't think this should be in some subdirectory of the config file parser. These are global project defaults, and should be in some toplevel directory. Probably next to the example ones.

We also need the meson changes to actually install the files. And we should install in /usr/share/hirte/ for the default files, and we should read both from there, as well as the sysadmin owned version in /etc.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not mix sources and config files, I'd put config files under conf top level subdirectory of the project.

You need to create meson.build in this directory and install those configuration files into etc:

install_data(sources : 'hirte.conf', install_dir : get_option('sysconfdir'))
install_data(sources : 'hirte-agent.conf', install_dir : get_option('sysconfdir'))

And then you need to adapt hirte.spec.in and add below to relevant packages:

%config %{_sysconfdir}/hirte.conf

%config %{_sysconfdir}/hirte-agent.conf

@ArtiomDivak ArtiomDivak force-pushed the add-config-file-to-etc branch 7 times, most recently from 44ffcae to f681de5 Compare February 13, 2023 09:30
@mwperina mwperina force-pushed the add-config-file-to-etc branch 2 times, most recently from 56e0674 to 130ce82 Compare February 13, 2023 12:25
Installs default config files to `/etc` directory:

* `hirte.conf` - a configuration file for the hirte daemon
* `hirte-agent.conf` - a configuration file for the hirte-agent daemon

Signed-off-by: ArtiomDivak <adivak@redhat.com>
@mwperina mwperina marked this pull request as ready for review February 13, 2023 13:59
@mwperina mwperina changed the title default config files Install default config files Feb 13, 2023
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi dismissed mwperina’s stale review February 13, 2023 14:56

requested change has been done

@engelmi engelmi merged commit e9c98b1 into eclipse-bluechi:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants