-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install default config files #125
Install default config files #125
Conversation
I think the idea of having some default config files is good, but the contents of these ones are very much not what we want to ship to users as some kind of default, its more like an example. Also, this is based on some older versions of the example files and loses recent changes. I also don't think this should be in some subdirectory of the config file parser. These are global project defaults, and should be in some toplevel directory. Probably next to the example ones. We also need the meson changes to actually install the files. And we should install in /usr/share/hirte/ for the default files, and we should read both from there, as well as the sysadmin owned version in /etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd not mix sources and config files, I'd put config files under conf
top level subdirectory of the project.
You need to create meson.build
in this directory and install those configuration files into etc:
install_data(sources : 'hirte.conf', install_dir : get_option('sysconfdir'))
install_data(sources : 'hirte-agent.conf', install_dir : get_option('sysconfdir'))
And then you need to adapt hirte.spec.in and add below to relevant packages:
%config %{_sysconfdir}/hirte.conf
%config %{_sysconfdir}/hirte-agent.conf
44ffcae
to
f681de5
Compare
56e0674
to
130ce82
Compare
Installs default config files to `/etc` directory: * `hirte.conf` - a configuration file for the hirte daemon * `hirte-agent.conf` - a configuration file for the hirte-agent daemon Signed-off-by: ArtiomDivak <adivak@redhat.com>
130ce82
to
c362515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Installs default config files to
/etc
directory:hirte.conf
- a configuration file for the hirte daemonhirte-agent.conf
- a configuration file for the hirte-agent daemonSigned-off-by: ArtiomDivak adivak@redhat.com