Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added initial dbus policy file templates and meson installation #169

Merged
merged 4 commits into from
Mar 1, 2023
Merged

added initial dbus policy file templates and meson installation #169

merged 4 commits into from
Mar 1, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Feb 27, 2023

This PR adds initial policy configuration files to grant hirte and hirte-agent to own the specified names on the system bus.

@engelmi engelmi marked this pull request as ready for review February 27, 2023 16:09
@engelmi
added initial dbus policy file templates and meson installation
d84356f 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi linked an issue Feb 27, 2023 that may be closed by this pull request
Research D-Bus permissions #164
Closed
@engelmi
added policy config files to rpm spec
694b2a4 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
fix file name typo
17b67cc 
Signed-off-by: Michael Engel <mengel@redhat.com>
@rhatdan
Copy link
Contributor

rhatdan commented Feb 28, 2023

LGTM

mwperina
mwperina approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mwperina
mwperina reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also enable usage of system dbus when building the project from RPM spec file?
Something like:

%meson_build -Dapi_bus=system

@engelmi
Copy link
Member Author

engelmi commented Mar 1, 2023

Could you please also enable usage of system dbus when building the project from RPM spec file? Something like:

%meson_build -Dapi_bus=system

Sure, added it. If the CI runs successful, I'll merge.

@engelmi
set api bus build option to use system bus on rpm build
64b6b68 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi merged commit 0f3ea6e into eclipse-bluechi:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sdunnagan sdunnagan Awaiting requested review from sdunnagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research D-Bus permissions
3 participants
@engelmi @rhatdan @mwperina