Check SPDX license header in source codes #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
mwperina
force-pushed
the
add-spdx-header
branch
from
fa48b2c
to
8dc1076
Compare
|
Action doesn't work if source code doesn't contain SPDX header enarx/spdx#16 |
mwperina
force-pushed
the
add-spdx-header
branch
2 times, most recently
from
c98ef0f
to
27c80b5
Compare
Each source file should contain SPDX license header to clearly identify the license it's published with. More information about SPDX can be found at: * https://opensource.com/article/18/1/spdx-and-licensing * https://spdx.dev/ Signed-off-by: Martin Perina <mperina@redhat.com>
1. Adds SPDX header mentioning GPL-2.0-or-later license into hirte original C source code files 2. Adds GPL-2.0-or-later into approved licenses Signed-off-by: Martin Perina <mperina@redhat.com>
Adds LGPL-2.1-or-later to the list of existing licenses, because it's used in `src/libhirte/common/list.h` containing list macros copied from systemd. Signed-off-by: Martin Perina <mperina@redhat.com>
Adds BSD-3-Clause to the list of existing licenses, because it's used in `src/libhirte/ini/`, which contains parsing of ini files copied from https://github.com/benhoyt/inih Signed-off-by: Martin Perina <mperina@redhat.com>
Adds MIT to the list of existing licenses, because it's used in `src/libhirte/hashmap/`, which contains hashmap implementation copied from https://github.com/tidwall/hashmap.c Signed-off-by: Martin Perina <mperina@redhat.com>
Adds SPDX header check also to XML files, which are included in hirte packages. Signed-off-by: Martin Perina <mperina@redhat.com>
Adds SPDX header check also to meson.build files. Signed-off-by: Martin Perina <mperina@redhat.com>
Adds SPDX header check also to shell files. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
add-spdx-header
branch
from
27c80b5
to
9c0abc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each source file should contain SPDX license header to clearly identify
the license it's published with.
More information about SPDX can be found at:
This PR adds checking SPDX headers in C, shell, XML and meson.build files.
Signed-off-by: Martin Perina mperina@redhat.com