Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rpm spec isses #216

Merged
merged 4 commits into from
Mar 21, 2023
Merged

fix rpm spec isses #216

merged 4 commits into from
Mar 21, 2023

Conversation

mwperina
Copy link
Member

  • Fix rpm-lint summary issues
  • Fix rpm-lint description-line-too-long issue
  • Fix rpm-lint conffile-without-noreplace-flag issue

@mwperina
Copy link
Member Author

Fixed:

hirte.x86_64: E: summary-too-long Hirte is a service orchestrator tool intended for multi-node devices (e.g.: edge devices) clusters
hirte.x86_64: W: name-repeated-in-summary Hirte
hirte.x86_64: E: description-line-too-long Hirte is a service orchestrator tool intended for multi-node devices (e.g.: edge devices) clusters with a predefined
hirte.x86_64: E: description-line-too-long number of nodes and with a focus on highly regulated environment such as those requiring functional safety (for example
hirte-agent.x86_64: E: description-line-too-long Hirte is a service orchestrator tool intended for multi-node devices (e.g.: edge devices) clusters with a predefined
hirte-agent.x86_64: E: description-line-too-long number of nodes and with a focus on highly regulated environment such as those requiring functional safety (for example
hirte.x86_64: W: conffile-without-noreplace-flag /etc/hirte/hirte.conf
hirte-agent.x86_64: W: conffile-without-noreplace-flag /etc/hirte/agent.conf

Leave as is, because we want that behavior:

hirte.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.containers.hirte.conf
hirte-agent.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.containers.hirte.Agent.conf

Leave as is for now, it can be fixed later:

hirte.x86_64: W: dbus-policy-allow-receive <allow receive_sender="org.containers.hirte"/> /etc/dbus-1/system.d/org.containers.hirte.conf
hirte.x86_64: W: dbus-policy-allow-receive <allow receive_sender="org.containers.hirte"/> /etc/dbus-1/system.d/org.containers.hirte.conf
hirte-agent.x86_64: W: dbus-policy-allow-receive <allow receive_sender="org.containers.hirte.Agent"/> /etc/dbus-1/system.d/org.containers.hirte.Agent.conf
hirte-agent.x86_64: W: dbus-policy-allow-receive <allow receive_sender="org.containers.hirte.Agent"/> /etc/dbus-1/system.d/org.containers.hirte.Agent.conf

All errors has been fixed, so rpm-lint should pass now

pypingou
pypingou reviewed Mar 21, 2023
View reviewed changes
hirte.spec.in Outdated Show resolved Hide resolved
engelmi
engelmi approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Fix rpm-lint summary issues
7bda27a 
* summary-too-long - summary shouldn't be longer than 79 characters
* name-repeated-in-summary

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Fix rpm-lint description-line-too-long issue
00d7b4b 
Lines in %description directive should not exceed 79 characters

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Fix rpm-lint conffile-without-noreplace-flag issue
a962043 
If user changes /etc/hirte/[hirte|agent].conf and we update the file
within RPM update, then the updated file will be saved as
/etc/hirte/[hirte|agent].conf.rpmnew

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Fix rpm-lint complains about relative path in Source
4cbf572 
Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina mwperina merged commit 52635a7 into eclipse-bluechi:main Mar 21, 2023
@mwperina mwperina deleted the fix-rpm-spec-isses branch March 21, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelmi engelmi engelmi approved these changes

@pypingou pypingou pypingou approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sdunnagan sdunnagan Awaiting requested review from sdunnagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwperina @pypingou @engelmi