-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the description of the project #218
Conversation
66742f0
to
21e2d48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These occurrences of orchestrator
might also be changed:
https://github.com/containers/hirte/blob/main/src/agent/agent.c#L1587
https://github.com/containers/hirte/blob/main/src/manager/node.c#L41
https://github.com/containers/hirte/blob/main/src/manager/node.c#L399
Yeah I wasn't sure if that line was "free-form" or not so I didn't dare changing it.
I didn't touch the code, but I saw these yes |
21e2d48
to
9711515
Compare
The first one is the bus description, which - I think - should be changed. The other two would be just for consistencies sake. Both don't have an impact on the behavior of hirte. |
9711515
to
61b2ede
Compare
Replace the use of the words "services orchestrator" by "services controller". Orchestrator comes with a certain understanding and expectations, especially around the management of containers, and we do not want to set these expectations for hirte. In addition, hirte isn't really an orchestrator by itself, it is just a part of an architecture that would be responsible for managing services. This commit thus adjusts the wording around the description of the project. Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
Adjusted :) |
61b2ede
to
f41df67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace the use of the words "services orchestrator" by "services controller". Orchestrator comes with a certain understanding and expectations, especially around the management of containers, and we do not want to set these expectations for hirte. In addition, hirte isn't really an orchestrator by itself, it is just a part of an architecture that would be responsible for managing services. This commit thus adjusts the wording around the description of the project. Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
Replace the use of the words "services orchestrator" by "services controller". Orchestrator comes with a certain understanding and expectations, especially around the management of containers, and we do not want to set these expectations for hirte. In addition, hirte isn't really an orchestrator by itself, it is just a part of an architecture that would be responsible for managing services. This commit thus adjusts the wording around the description of the project. Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
Replace the use of the words "services orchestrator" by "services controller". Orchestrator comes with a certain understanding and expectations, especially around the management of containers, and we do not want to set these expectations for hirte.
In addition, hirte isn't really an orchestrator by itself, it is just a part of an architecture that would be responsible for managing services.
This commit thus adjusts the wording around the description of the project.