Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the description of the project #218

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Adjust the description of the project #218

merged 1 commit into from
Mar 22, 2023

Conversation

pypingou
Copy link
Member

Replace the use of the words "services orchestrator" by "services controller". Orchestrator comes with a certain understanding and expectations, especially around the management of containers, and we do not want to set these expectations for hirte.
In addition, hirte isn't really an orchestrator by itself, it is just a part of an architecture that would be responsible for managing services.

This commit thus adjusts the wording around the description of the project.

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pypingou
Copy link
Member Author

pypingou commented Mar 22, 2023

https://github.com/containers/hirte/blob/main/src/agent/agent.c#L1587

Yeah I wasn't sure if that line was "free-form" or not so I didn't dare changing it.

https://github.com/containers/hirte/blob/main/src/manager/node.c#L41
https://github.com/containers/hirte/blob/main/src/manager/node.c#L399

I didn't touch the code, but I saw these yes

@engelmi
Copy link
Member

engelmi commented Mar 22, 2023

https://github.com/containers/hirte/blob/main/src/agent/agent.c#L1587

Yeah I wasn't sure if that line was "free-form" or not so I didn't dare changing it.

https://github.com/containers/hirte/blob/main/src/manager/node.c#L41
https://github.com/containers/hirte/blob/main/src/manager/node.c#L399

I didn't touch the code, but I saw these yes

The first one is the bus description, which - I think - should be changed. The other two would be just for consistencies sake. Both don't have an impact on the behavior of hirte.

README.md Outdated Show resolved Hide resolved
Replace the use of the words "services orchestrator" by "services
controller". Orchestrator comes with a certain understanding and
expectations, especially around the management of containers, and we do
not want to set these expectations for hirte.
In addition, hirte isn't really an orchestrator by itself, it is just a
part of an architecture that would be responsible for managing services.

This commit thus adjusts the wording around the description of the
project.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
@pypingou
Copy link
Member Author

https://github.com/containers/hirte/blob/main/src/agent/agent.c#L1587

Yeah I wasn't sure if that line was "free-form" or not so I didn't dare changing it.

https://github.com/containers/hirte/blob/main/src/manager/node.c#L41
https://github.com/containers/hirte/blob/main/src/manager/node.c#L399

I didn't touch the code, but I saw these yes

The first one is the bus description, which - I think - should be changed. The other two would be just for consistencies sake. Both don't have an impact on the behavior of hirte.

Adjusted :)

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pypingou pypingou merged commit 8941ccd into main Mar 22, 2023
@pypingou pypingou deleted the drop_orchestrator branch March 22, 2023 10:44
mwperina pushed a commit to mwperina/bluechi that referenced this pull request Mar 23, 2023
Replace the use of the words "services orchestrator" by "services
controller". Orchestrator comes with a certain understanding and
expectations, especially around the management of containers, and we do
not want to set these expectations for hirte.
In addition, hirte isn't really an orchestrator by itself, it is just a
part of an architecture that would be responsible for managing services.

This commit thus adjusts the wording around the description of the
project.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
mwperina pushed a commit that referenced this pull request Mar 23, 2023
Replace the use of the words "services orchestrator" by "services
controller". Orchestrator comes with a certain understanding and
expectations, especially around the management of containers, and we do
not want to set these expectations for hirte.
In addition, hirte isn't really an orchestrator by itself, it is just a
part of an architecture that would be responsible for managing services.

This commit thus adjusts the wording around the description of the
project.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants