Heartbeat interval configurable #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
sdunnagan
approved these changes
Mar 27, 2023
Signed-off-by: Michael Engel <mengel@redhat.com>
Signed-off-by: Michael Engel <mengel@redhat.com>
Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
heartbeat_interval_configurable
branch
from
2d94c92
to
13e0f15
Compare
mwperina
reviewed
Mar 28, 2023
| @@ -26,6 +26,10 @@ ManagerHost= | |||
| # CLI options. | |||
| #ManagerAddress= | |||
|
|
|||
| # | |||
| # Defines the interval between two heartbeat signals sent to hirte in milliseconds. | |||
| #HeartbeatInterval= | |||
There was a problem hiding this comment.
Does the option have a default value? If so, please add it here
| @@ -22,6 +22,10 @@ ManagerPort=842 | |||
| # CLI options. | |||
| ManagerAddress= | |||
|
|
|||
| # | |||
| # Defines the interval between two heartbeat signals sent to hirte in milliseconds. | |||
| HeartbeatInterval= | |||
| #### **--interval**, **-i** | ||
|
|
||
| The interval between two heartbeat signals sent to hirte in milliseconds. This option will overwrite the heartbeat interval defined in the configuration file. | ||
|
|
| #### **HeartbeatInterval** (long) | ||
|
|
||
| The interval between two heartbeat signals sent to hirte in milliseconds. This option will overwrite the heartbeat interval defined in the configuration file. | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #133 and makes the heartbeat interval configurable via CLI option as well as configuration file.